Re: [PATCH] Porting small OpenBSD changes. - Mailing list pgsql-hackers

From David CARLIER
Subject Re: [PATCH] Porting small OpenBSD changes.
Date
Msg-id CA+XhMqwexi1Cq0MBFpRfynNtPb9Qad3mcCzZbrK23O0PvQbK8g@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Porting small OpenBSD changes.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Porting small OpenBSD changes.
List pgsql-hackers
I m not against, I would go with your final version too. Thanks !

On 20 November 2017 at 22:36, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I wrote:
> I still dare to doubt whether you've tested this, because AFAICS
> the operand numbering is wrong.  The "r"(lock) operand is number 3
> given these operand declarations, not number 2.

Oh, my apologies, scratch that.  Evidently I put in the "+m"(*lock)
operand and confused myself about what was what.

I still think the form I proposed is better style though.

                        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Porting small OpenBSD changes.
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.