Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin-hackers] pgAdmin 4 commit: Create screenshots whenfeature tests fail. - Mailing list pgadmin-hackers

From Atira Odhner
Subject Re: [pgadmin-hackers] pgAdmin 4 commit: Create screenshots whenfeature tests fail.
Date
Msg-id CA+Vc24qHgvYdEvEaE9Bt+yHpXxiZPsDTQ1i+F3bXq_b6d-Bw9g@mail.gmail.com
Whole thread Raw
In response to [pgadmin-hackers] pgAdmin 4 commit: Create screenshots when feature tests fail.  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hey Dave, looks like we missed the .keep file in the screenshots directory when applying this patch.
It's making screenshots fail to be captured when the directory doesn't exist (e.g. in CI).



On Thu, Mar 9, 2017 at 10:34 AM, Dave Page <dpage@pgadmin.org> wrote:
Create screenshots when feature tests fail.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d756f2f6c637e52951356948ad0c188f66689be6
Author: Joao Pedro De Almeida Pereira <jpereira@pivotal.io>

Modified Files
--------------
.../connect_to_server_feature_test.py              |  6 +-
.../template_selection_feature_test.py             |  6 +-
.../settings/templates/settings/settings.js        |  8 ++-
web/regression/.gitignore                          |  1 +
web/regression/feature_utils/base_feature_test.py  | 73 +++++++++++++++++++---
web/regression/feature_utils/pgadmin_page.py       | 13 +++-
web/regression/test_utils.py                       |  2 +-
7 files changed, 87 insertions(+), 22 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Attachment

pgadmin-hackers by date:

Previous
From: Atira Odhner
Date:
Subject: Re: [pgadmin-hackers] [patch] Refactor: clipboard, translations, jasmine
Next
From: Joao Pedro De Almeida Pereira
Date:
Subject: [pgadmin-hackers][patch] Update Selenium and Chrome driver