Re: [pgadmin-hackers][Patch] Bypass recovery state for Greenplum - Mailing list pgadmin-hackers

From Atira Odhner
Subject Re: [pgadmin-hackers][Patch] Bypass recovery state for Greenplum
Date
Msg-id CA+Vc24ooAvKC8hNC3i-LvJwr0cESD2QEQ_fAepM63oCJg4DsvA@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers][Patch] Bypass recovery state for Greenplum  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers][Patch] Bypass recovery state for Greenplum  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Whoops we accidentally left in hardcoded db config we used for running tests from our IDE.

Here's a fixed patch.

On Mon, Jan 30, 2017 at 6:45 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, Jan 27, 2017 at 5:18 PM, George Gelashvili
<ggelashvili@pivotal.io> wrote:
> This bypasses checking if the DB is in recovery for versions of postgres
> that don't support pg_is_in_recovery() (anything pre-9.0, such as
> Greenplum).
>
> This patch depends on the "Refactor sql template version picking" patch.

The regression test included with this patch fail for me:

======================================================================
ERROR: runTest (pgadmin.browser.server_groups.servers.templates.connect.sql.tests.test_check_recovery.TestCheckRecovery)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/templates/connect/sql/tests/test_check_recovery.py",
line 23, in runTest
    self.server['port']).cursor()
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
32, in get_db_connection
    port=port)
  File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/psycopg2/__init__.py",
line 164, in connect
    conn = _connect(dsn, connection_factory=connection_factory, async=async)
OperationalError: fe_sendauth: no password supplied

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Attachment

pgadmin-hackers by date:

Previous
From: Atira Odhner
Date:
Subject: Re: [pgadmin-hackers][Patch] Refactor sql template version picking
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Bypass recovery checks with older servers. This isre