On Tue, 6 Feb 2024 at 16:22, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
I'm not convinced we need a new file to disable ALTER SYSTEM. I feel like an "enable_alter_system" GUC that defaults to ON would work fine for this. If we make that GUC be PGC_POSTMASTER then an operator can disable ALTER SYSTEM either with a command line argument or by changing the main config file. Since this feature is mostly useful when the config file is managed by an external system, it seems rather simple for that system to configure one extra GUC in the config file.
This is mostly the approach I have taken in the patch, except allowing to change the value in the configuration file. The patch at the moment was enforcing just the setting at startup (which is more than enough for a Kubernetes operator given that Postgres runs in the container). I had done some experiments enabling the change in the configuration file, but wasn't sure in which `config_group` to place the 'enable_alter_system` GUC, based on the src/include/utils/guc_tables.h. Any thoughts/hints?
