Re: Proposal : REINDEX SCHEMA - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Proposal : REINDEX SCHEMA
Date
Msg-id CA+U5nMLGekYxAvdK4+MgSjYYHPPndVdkz7Zgoqk8gPQxDeQSZQ@mail.gmail.com
Whole thread Raw
In response to Re: Proposal : REINDEX SCHEMA  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Proposal : REINDEX SCHEMA  (Michael Paquier <michael.paquier@gmail.com>)
Re: Proposal : REINDEX SCHEMA  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 9 December 2014 at 17:17, Michael Paquier <michael.paquier@gmail.com> wrote:

>> While re-looking at that. I just found that when selecting the
>> relations that are reindexed for a schema we ignore materialized view
>> as the key scan is only done using 'r' as relkind. The patch attached
>> fixes that.
> Here is an updated patch doing as well that:
> - Regression test checking if user has permissions on schema was broken
> - Silent NOTICE messages of REINDEX by having client_min_messages set
> to WARINING (thoughts about having a plpgsql function doing
> consistency checks of relfilenode before and after reindex?)

ISTM that REINDEX is not consistent with VACUUM, ANALYZE or CLUSTER in
the way it issues NOTICE messages.

I'm inclined to simply remove the NOTICE messages, except when a
REINDEX ... VERBOSE is requested.

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Scaling shared buffer eviction
Next
From: Sawada Masahiko
Date:
Subject: Re: Proposal : REINDEX SCHEMA