On 30 October 2014 08:43, Haribabu Kommi <kommi.haribabu@gmail.com> wrote:
> I marked the patch as ready for committer.
This looks very interesting.
The value of the patch seems to come from skipping costly checks. Your
performance test has a leading VARCHAR column, so in that specific
case skipping the leading column is a big win. I don't see it would be
in all cases.
Can we see a few tests on similar things to check for other
opportunities and regressions.
* Single column bigint index
* Multi-column bigint index
* 5 column index with mixed text and integers
The explanatory comments need some work to more clearly explain what
this patch does.
-- Simon Riggs http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
