Re: btvacuumpage useless "orig_blkno" - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: btvacuumpage useless "orig_blkno"
Date
Msg-id CA+U5nMKJSbE-9qJO25QQ_6ns1ZEi=ww07eVm7bfPZQQRHngxFg@mail.gmail.com
Whole thread Raw
In response to btvacuumpage useless "orig_blkno"  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: btvacuumpage useless "orig_blkno"
List pgsql-hackers
On Mon, Nov 21, 2011 at 10:03 PM, Alvaro Herrera
<alvherre@alvh.no-ip.org> wrote:
> I just noticed that btvacuumpage has two BlockNumber parameters -- blkno
> and orig_blkno.  The only caller passes them as the same value; the
> header comments state that blkno would be different when recursing, but
> actually the function implements recursion internally by way of a cute
> "goto" trick.  So it seems to me that the orig_blkno parameter is
> useless -- we could just remove it.
>
> Unless I'm completely missing something?

tail recursion - read comments at bottom of the function

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: btvacuumpage useless "orig_blkno"
Next
From: Alvaro Herrera
Date:
Subject: Re: btvacuumpage useless "orig_blkno"