On Fri, Jan 6, 2012 at 1:10 AM, Stephen Frost <sfrost@snowman.net> wrote:
> * Simon Riggs (simon@2ndQuadrant.com) wrote:
>> I discover that non-all-zeroes holes are fairly common, just not very frequent.
>
> Curious, might be interesting to find out why.
>
>> That may or may not be a problem, but not something to be dealt with
>> here and now.
>
> But I agree that it's not the job of this patch/effort. It sounds like
> we have clear indication, however, that those areas, as they are not
> necessairly all zeros, should be included in the checksum.
Disagree. Full page writes ignore the hole, so its appropriate to do
so here also.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
