Re: [COMMITTERS] pgsql: Allow external recovery_config_directory - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Date
Msg-id CA+U5nMJe+Oxso++m1JyrkzLtwZMXMQrYRhdAuPzp0RVcc-w_gw@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Allow external recovery_config_directory  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: [COMMITTERS] pgsql: Allow external recovery_config_directory  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
On 27 March 2013 21:05, Heikki Linnakangas <hlinnakangas@vmware.com> wrote:

>> Same argument applies to all conf files, not just recovery.conf.
>>
>> Sounds like the patch to add -R to pg_basebackup should be revoked as
>> being not well thought out. Or it should be fixed, in which case this
>> works the same.
>
> What exactly was wrong with pg_basebackup -R, without
> recovery_config_directory?

You asked me to answer the question. I did. Please answer mine.

Why do you think recovery_config_directory are different to
config_file with respect to pg_basebackup?
It looks like you've discovered a problem with pg_basebackup, not a
problem with this patch.

-- Simon Riggs                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Next
From: Simon Riggs
Date:
Subject: Re: Catching resource leaks during WAL replay