Re: pgsql: Fast promote mode skips checkpoint at end of recovery. - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Fast promote mode skips checkpoint at end of recovery.
Date
Msg-id CA+U5nMJaTFK3Ykc+M8BYCeE52dwzdkvJtA5r-OufKYykBKcYAw@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fast promote mode skips checkpoint at end of recovery.  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-committers
On 29 January 2013 12:19, Heikki Linnakangas <hlinnakangas@vmware.com> wrote:

> You might want to bring the database up ASAP after restoring. If the user
> requests that, the system shouldn't second-guess that.

In later releases we can relax further, if that is justified. I call
this acting conservatively in the interests of robustness.

> PS. I think the implicit judgment you made that "pg_ctl promote" is now the
> preferred method of promoting the server, over the trigger file method,
> needs more discussion. I'm not sure I agree with that, but if we do that,
> the docs should emphasize the pg_ctl promote more than the trigger file.

So why did you commit a second method?

> Also, I don't like conflating the shutdown mode argument with promotion mode
> either, in pg_ctl. Perhaps it would be best to revert this and take some
> more time to discuss the right behavior and user interface for this (if it
> needs one).

I don't think so. This was discussed on list. You are asking for
additional features, which I've explained why they aren't added by me.
We have time left to add them, but these minor points aren't more
important than other patches in the queue.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Fast promote mode skips checkpoint at end of recovery.
Next
From: Fujii Masao
Date:
Subject: Re: pgsql: Fast promote mode skips checkpoint at end of recovery.