Postgres Pro
Downloads
Home   >   mailing lists

Re: corrupt pages detected by enabling checksums - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: corrupt pages detected by enabling checksums
Date
Msg-id CA+U5nMJAytudAQHCU+hdLwUuc4JGqimP+jQNvkTn-RpwA9P_zw@mail.gmail.com
Whole thread Raw
In response to Re: corrupt pages detected by enabling checksums  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: corrupt pages detected by enabling checksums
List pgsql-hackers
Tree view
On 6 April 2013 15:44, Andres Freund <andres@2ndquadrant.com> wrote:
 
> * In xlog_redo, it seemed slightly awkward to call XLogRecGetData twice.
> Merely a matter of preference but I thought I would mention it.

Youre absolutely right, memcpy should have gotten passed 'data', not
XLogRecGetData().

Applied, with this as the only code change.

Thanks everybody for good research and coding and fast testing.

We're in good shape now.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Enabling Checksums
Next
From: "Etsuro Fujita"
Date:
Subject: Re: Patch for removng unused targets