Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait
Date
Msg-id CA+U5nM+RHC=4nvqK3mpjoH_tk2MFoQV9XKdp=PgaO6JggsDn+g@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Tue, Aug 2, 2011 at 8:23 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Simon Riggs <simon@2ndQuadrant.com> writes:
>> On Tue, Aug 2, 2011 at 6:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Fix incorrect initialization of ProcGlobal->startupBufferPinWaitBufId.
>>>
>>> It was initialized in the wrong place and to the wrong value.  With bad
>>> luck this could result in incorrect query-cancellation failures in hot
>>> standby sessions, should a HS backend be holding pin on buffer number 1
>>> while trying to acquire a lock.
>
>> Did I miss a bug report?
>
> No, this was something I happened across in code-reading a few weeks ago
> and had a note to myself to fix.  While looking at it today I found more
> problems ... see second commit.

I'm happy to fix problems I've caused that are reported to me.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait
Next
From: andrewsn@pgfoundry.org (User Andrewsn)
Date:
Subject: ip4r - ip4r: First cut at ip6/ip6r/ipaddress/iprange support (2.0