Re: Moving more work outside WALInsertLock - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Moving more work outside WALInsertLock
Date
Msg-id CA+U5nM+QaEZfdU-HBo2JzT0m8r6-Rb7hTLAuN75BtH8f5d-+5g@mail.gmail.com
Whole thread Raw
In response to Re: Moving more work outside WALInsertLock  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
On Thu, Dec 15, 2011 at 7:06 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:

>> Please try again to explain what you're doing?
>
>
> Ok: I'm moving the creation of rdata entries for backup blocks outside the
> critical section, so that it's done before grabbing the lock. I'm also
> moving the CRC calculation so that it's done after all the rdata entries
> have been created, including the ones for backup blocks. It's more readable
> to do it that way, as a separate step, instead of sprinkling the COMP_CRC
> macros in many places.

There's a comment that says we can't undo the linking of the rdata
chains, but it looks like a reversible process to me.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: JSON for PG 9.2
Next
From: Simon Riggs
Date:
Subject: Re: Moving more work outside WALInsertLock