Re: Fix for gistchoose - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Fix for gistchoose
Date
Msg-id CA+TgmobtX7Fzz9jB3YfaAQihvW8fGL+YLz0ZfM=48cQxUAAJUg@mail.gmail.com
Whole thread Raw
In response to Fix for gistchoose  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: Fix for gistchoose
Re: Fix for gistchoose
List pgsql-hackers
On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov
<aekorotkov@gmail.com> wrote:
> I found that code of gistchoose doesn't follow it's logic. Idea of
> gistchoose is that first column penalty is more important than penalty of
> second column. If we meet same penalty values of first column then we choose
> minimal penalty value of second column among them.

Nice catch.  Thanks for the patch, which I have now committed.  But
since these functions were very short on useful comments, I added
some.  Hopefully they're even right, but let me know if you think
otherwise, or have any ideas for further improvement.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Joe Abbate
Date:
Subject: Re: pg_operator.oprcode in 9.2rc1
Next
From: Robert Haas
Date:
Subject: Re: Don't allow relative path for copy from file