Re: Fix for gistchoose - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Fix for gistchoose
Date
Msg-id CAPpHfdv12be==ckYJ=7a+D6RuGqRC=D2k0MeqF-JxxEAwBRsFQ@mail.gmail.com
Whole thread
In response to Re: Fix for gistchoose  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Aug 30, 2012 at 9:11 PM, Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov
<aekorotkov@gmail.com> wrote:
> I found that code of gistchoose doesn't follow it's logic. Idea of
> gistchoose is that first column penalty is more important than penalty of
> second column. If we meet same penalty values of first column then we choose
> minimal penalty value of second column among them.

Nice catch.  Thanks for the patch, which I have now committed.  But
since these functions were very short on useful comments, I added
some.  Hopefully they're even right, but let me know if you think
otherwise, or have any ideas for further improvement.

Thanks! Comments looks good for me.

------
With best regards,
Alexander Korotkov.

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: splitting *_desc routines
Next
From: Robert Haas
Date:
Subject: Re: patch: shared session variables