Postgres Pro
Downloads
Home   >   mailing lists

Re: Add pg_file_sync() to adminpack - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Add pg_file_sync() to adminpack
Date
Msg-id CA+TgmobsFt0pfNCihaFJK9EE-hA+CHPiwmv9t9P_JbPAGhZnUA@mail.gmail.com
Whole thread Raw
In response to Re: Add pg_file_sync() to adminpack  (Atsushi Torikoshi <atorik@gmail.com>)
Responses Re: Add pg_file_sync() to adminpack  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Tue, Jan 14, 2020 at 10:08 AM Atsushi Torikoshi <atorik@gmail.com> wrote:
> fails we can get error messages. So it seems straightforward for me to
>  'return true on success and emit an ERROR otherwise'.

I agree with reporting errors using ERROR, but it seems to me that we
ought to then make the function return 'void' rather than 'bool'.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: [PATCH v1] pg_ls_tmpdir to show directories
Next
From: Li Japin
Date:
Subject: Code cleanup for build_regexp_split_result