Re: [HACKERS] Confusing error message in pgbench - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Confusing error message in pgbench
Date
Msg-id CA+TgmobrpYNSNfoVtc=ELyLO6pD-LwZq20oCW9URLdrmqrNATw@mail.gmail.com
Whole thread Raw
In response to [HACKERS] Confusing error message in pgbench  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: [HACKERS] Confusing error message in pgbench  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [HACKERS] Confusing error message in pgbench  (Tatsuo Ishii <ishii@sraoss.co.jp>)
List pgsql-hackers
On Tue, Aug 1, 2017 at 10:03 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
> I found an error message in pgbench is quite confusing.
>
> pgbench -S -M extended -c 1 -T 30 test
> query mode (-M) should be specified before any transaction scripts (-f or -b)
>
> Since there's no -f or -b option is specified, users will be
> confused. Actually the error occurs because pgbench implicitly
> introduces a built in script for -S. To eliminate the confusion, I
> think the error message should be fixed like this:
>
> query mode (-M) should be specified before transaction type (-S or -N) or any transaction scripts (-f or -b)
>
> Patch attached.

Not really objecting, but an even better fix might be to remove the
restriction on the order in which the options can be specified.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] typo for using "OBJECT_TYPE" for "security label ondomain" in "gram.y"
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization