Re: A Typo in regress/sql/privileges.sql - Mailing list pgsql-hackers

From Robert Haas
Subject Re: A Typo in regress/sql/privileges.sql
Date
Msg-id CA+Tgmobq7GT=DdPxYb0tSHkyY2zVfWZxPrRLiG35MH=abjG5aw@mail.gmail.com
Whole thread Raw
In response to A Typo in regress/sql/privileges.sql  (Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>)
Responses Re: A Typo in regress/sql/privileges.sql  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Wed, Dec 16, 2015 at 11:51 PM, Tatsuro Yamada
<yamada.tatsuro@lab.ntt.co.jp> wrote:
> I found typos in privileges.sql and privileges.out
> Please find attached a patch.

Thanks, good catch.  But even aside from this particular issue, isn't
that comment in need of a little more love?  An inference means a
deduction, or something you can figure out from something else.  ON
CONFLICT (four) is not an inference.  Why don't we say:

-- Check that the columns in the ON CONFLICT clause require select privileges

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch: ResourceOwner optimization for tables with many partitions
Next
From: Peter Geoghegan
Date:
Subject: Re: Using quicksort for every external sort run