Re: Crash in partition-wise join involving dummy partitioned relation - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Crash in partition-wise join involving dummy partitioned relation
Date
Msg-id CA+TgmobnASYx2Cqcp1gbuhCu_WAVtUcef2yTC=3QfOYDpCp4CA@mail.gmail.com
Whole thread Raw
In response to Re: Crash in partition-wise join involving dummy partitioned relation  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
On Mon, Feb 5, 2018 at 11:02 PM, Ashutosh Bapat
<ashutosh.bapat@enterprisedb.com> wrote:
> The comment says why it checks both bounds and part_scheme, but it
> doesn't explain why we check nparts, part_rels etc. My patch had that
> explanation.

Hmm, well, I couldn't understand it from your comment.  I'm fine with
adding more explanation, but it needs to be brief yet clear.

> Or may be with these changes those checks are not needed.
> Should we remove those?

I think you had them there originally so that you could Assert() on
them, but I do suspect that they're not all needed at runtime.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] MERGE SQL Statement for PG11
Next
From: Robert Haas
Date:
Subject: Re: RelOptInfo -> Relation