Re: Damage control for planner's get_actual_variable_endpoint() runaway - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Damage control for planner's get_actual_variable_endpoint() runaway
Date
Msg-id CA+Tgmobn59GXb28h5Yj8=98xJcTMZgsMoffONXA6t-yuHXdEwQ@mail.gmail.com
Whole thread Raw
In response to Re: Damage control for planner's get_actual_variable_endpoint() runaway  (Andres Freund <andres@anarazel.de>)
Responses Re: Damage control for planner's get_actual_variable_endpoint() runaway
Re: Damage control for planner's get_actual_variable_endpoint() runaway
List pgsql-hackers
On Mon, Nov 21, 2022 at 1:17 PM Andres Freund <andres@anarazel.de> wrote:
> On November 21, 2022 9:37:34 AM PST, Robert Haas <robertmhaas@gmail.com> wrote:
> >On Mon, Nov 21, 2022 at 12:30 PM Andres Freund <andres@anarazel.de> wrote:
> >> This can't quite be right - isn't this only applying the limit if we found a
> >> visible tuple?
> >
> >It doesn't look that way to me, but perhaps I'm just too dense to see
> >the problem?
>
> The earlier version didn't have the issue, but the latest seems to only limit after a visible tuple has been found.
Notethe continue; when fetching a heap tuple fails.
 

Oh, that line was removed in Simon's patch but not in Jakub's version,
I guess. Jakub's version also leaves out the last_block = block line
which seems pretty critical.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [BUG] FailedAssertion in SnapBuildPurgeOlderTxn
Next
From: Ted Toth
Date:
Subject: [PATCH] Add <> support to sepgsql_restorecon