Re: pgsql: Recursively fsync() the data directory after a crash. - Mailing list pgsql-committers

From Robert Haas
Subject Re: pgsql: Recursively fsync() the data directory after a crash.
Date
Msg-id CA+TgmobjLyAGC_e6MHn_mNfBVibE7JKYQtE22AS8pLwfsMDoQA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Recursively fsync() the data directory after a crash.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Recursively fsync() the data directory after a crash.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Mon, May 18, 2015 at 11:04 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Sun, May 17, 2015 at 9:44 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
>>> If there a reason why in pre_sync_fname(), the error message does not
>>> contain a %m?
>
>> For consistency with the rest of the file, I suppose.  Not sure why
>> it's like that, but all the functions in the file do it that way.
>
> Huh?  All the ones that are reporting kernel call failures certainly
> have %m.

Oops, you're right.  I was looking at the wrong code.  Yeah, that
should probably be fixed.  I'm not sure it's a good idea to do that
right now though.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: hstore_plpython: Fix regression tests under Python 3
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Recursively fsync() the data directory after a crash.