Re: Moving src/backend/utils/misc/rbtree.c to src/backend/lib - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Moving src/backend/utils/misc/rbtree.c to src/backend/lib
Date
Msg-id CA+TgmobgF-D7BHBF0G-yn5w+Ug+50EwC1goYMmwhb4ZqwKTJCQ@mail.gmail.com
Whole thread Raw
In response to Moving src/backend/utils/misc/rbtree.c to src/backend/lib  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
On Mon, Dec 22, 2014 at 5:16 AM, Heikki Linnakangas
<hlinnakangas@vmware.com> wrote:
> Peter Geoghegan suggested [1] moving rbtree.c to src/backend/lib, which I
> think makes a lot of sense. Now that we have several other general purpose
> data structures in src/backend/lib (linked lists, a binary heap, and a
> pairing heap), rbtree.c would definitely be better placed in
> src/backend/lib, too.
>
> The usual objection to moving things is that it makes back-patching harder.
> It also might break third-party code that use it (since presumably we would
> also move the .h file). Nevertheless, I feel the advantages outweigh the
> disadvantages in this case.

I agree.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: inherit support for foreign tables
Next
From: Tom Lane
Date:
Subject: Re: Final Patch for GROUPING SETS