Postgres Pro
Downloads
Home   >   mailing lists

Re: allow_in_place_tablespaces vs. pg_basebackup - Mailing list pgsql-hackers

From Robert Haas
Subject Re: allow_in_place_tablespaces vs. pg_basebackup
Date
Msg-id CA+Tgmobf-Ra_vAqX8LywPxQ5UL-qHsU3tA45Ay9JwGkCcmROnA@mail.gmail.com
Whole thread Raw
In response to Re: allow_in_place_tablespaces vs. pg_basebackup  (Michael Paquier <michael@paquier.xyz>)
Responses Re: allow_in_place_tablespaces vs. pg_basebackup  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Mar 21, 2023 at 7:59 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Mon, Mar 20, 2023 at 07:56:42AM -0400, Robert Haas wrote:
> > Anyone want to comment on this?
>
> I have not checked the patch in details, but perhaps this needs at
> least one test?

Sure. I was sort of hoping to get feedback on the overall plan first,
but it's easy enough to add a test so I've done that in the attached
version. I've put it in a separate file because 010_pg_basebackup.pl
is pushing a thousand lines and it's got a ton of unrelated tests in
there already. The test included here fails on master, but passes with
the patch.

--
Robert Haas
EDB: http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Set arbitrary GUC options during initdb
Next
From: Melanie Plageman
Date:
Subject: Re: Add pg_walinspect function with block info columns