Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it
Date
Msg-id CA+TgmobdbkjCEhiHf8yeP_aYwzKAEBU5FeYCBbcqtiOGiim2gg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it
Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it
Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it
List pgsql-hackers
Tree view 
On Tue, Jan 8, 2013 at 3:00 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> Uhm, we don't have & need palloc support and I don't think
> relpathbackend() is a good justification for adding it.

FWIW, I'm with Tom on this one.  Any meaningful code sharing is going
to need that, so we might as well bite the bullet.

And functions that return static buffers are evil incarnate.  I've
spent way too much of my life dealing with the supreme idiocy that is
fmtId().  If someone ever finds a way to make that go away, I will buy
them a beverage of their choice at the next conference we're both at.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers
Next
From: Tom Lane
Date:
Subject: Re: Weird Assert failure in GetLockStatusData()