Re: pgsql: Server-side gzip compression. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pgsql: Server-side gzip compression.
Date
Msg-id CA+TgmobSeRFM84pwa5HfZCGRx=Q-iFfPFZfq-4=t1p04yxg_Og@mail.gmail.com
Whole thread Raw
Responses Re: pgsql: Server-side gzip compression.
List pgsql-hackers
On Tue, Jan 25, 2022 at 4:20 AM David Rowley <dgrowleyml@gmail.com> wrote:
> On Tue, 25 Jan 2022 at 09:14, Robert Haas <rhaas@postgresql.org> wrote:
> > src/backend/replication/basebackup_gzip.c | 309 ++++++++++++++++++++++++++++++
>
> This could do with the attached.  MSVC compilers need a bit more
> reassurance that ereport/elog ERRORs don't return.

Err, well, if we need it, we need it. It surprises me, though:
wouldn't this same consideration apply to a very large number of other
places in the code base?

-- 
Robert Haas
EDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: Correct error message for end-of-recovery record TLI
Next
From: Robert Haas
Date:
Subject: Re: Non-decimal integer literals