Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Patch to implement pg_current_logfile() function - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Patch to implement pg_current_logfile() function
Date
Msg-id CA+TgmobQz=+LguYcYQ=v6ZWzSB=LAH=Gh2_xuMQggyV73zUCsA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Patch to implement pg_current_logfile() function  ("Karl O. Pinc" <kop@meme.com>)
Responses Re: [HACKERS] Patch to implement pg_current_logfile() function  ("Karl O. Pinc" <kop@meme.com>)
List pgsql-hackers
Tree view 
On Fri, Mar 3, 2017 at 7:21 PM, Karl O. Pinc <kop@meme.com> wrote:
> But if the code does not exit the loop then
> before calling elog(ERROR), shouldn't it
> also call FreeFile(fd)?

Hmm.  Normally error recovery cleans up opened files, but since
logfile_open() directly calls fopen(), that's not going to work here.
So that does seem to be a problem.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Patch to implement pg_current_logfile() function
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] Cost model for parallel CREATE INDEX