Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_test_fsync file descriptor leak - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_test_fsync file descriptor leak
Date
Msg-id CA+TgmobQcSSms=3QsbhpERriHL26eb0wJ3m6FEs0S-0v3sLzzw@mail.gmail.com
Whole thread Raw
In response to pg_test_fsync file descriptor leak  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Nov 18, 2014 at 3:41 PM, Jeff Janes <jeff.janes@gmail.com> wrote:
> The open_datasync code opens the output file as a test to make sure the
> flags are accepted by the OS, and if it succeeds it then immediately opens
> the file again with the same flags, overwriting and so leaking the
> descriptor from the previous open.
>
> On Windows MinGW, this prevents the final unlink from working, as the file
> is still open.
>
> Trivial fix attached.

Committed and back-patched to 9.1.  Thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: What exactly is our CRC algorithm?
Next
From: Peter Geoghegan
Date:
Subject: Re: Doing better at HINTing an appropriate column within errorMissingColumn()