Re: SortSupport for UUID type - Mailing list pgsql-hackers

From Robert Haas
Subject Re: SortSupport for UUID type
Date
Msg-id CA+TgmobPizka6kXPfUcaOPwqUGUuVJAX-FggBqf8W942mcbBLA@mail.gmail.com
Whole thread Raw
In response to Re: SortSupport for UUID type  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: SortSupport for UUID type  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
On Fri, Nov 6, 2015 at 3:35 AM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello, I tried to look on this as far as I can referring to
> numeric.c..

Oops, I didn't see this review before committing.

> 6. uuid_abbrev_convert()
>
>  > memcpy((char *) &res, authoritative->data, sizeof(Datum));
>
>  memcpy's prototype is "memcpy(void *dest..." so the cast to
>  (char *) is not necessary.

This is a good catch, so I pushed a fix.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: SortSupport for UUID type
Next
From: Robert Haas
Date:
Subject: Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby