On Thu, Sep 10, 2015 at 3:43 AM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Generated lwlocknames.[ch] don't have header comment because
> generate-lwlocknames.pl writes them into wrong place.
>
> lmgr/Makefile looks to have some mistakes.
Fixed.
> - lwlocknames.c is not generated from (or using) lwlocknames.c
> so the entry "lwlocknames.c: lwlocknames.h" doesn't looks to
> be appropriate.
I think that's a pretty standard way of handling a case where a single
command generates multiple files.
> - maintainer-clean in lmgr/Makefile forgets to remove lwlocknames.c.
Fixed.
> Perhaps uncommenting in pg_config_manual.h is left alone.
> (This is not included in the diff below)
Fixed.
And committed. Thanks for the review, let's see what the buildfarm thinks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
