Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically.
Date
Msg-id CA+TgmobM-sKsEtfY+w0g0+k5kpT+Hqa0cHEwHRG0HLAoVCOeiQ@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically.  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically.
List pgsql-hackers
On Sat, Jul 20, 2013 at 12:39 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
>> I don't have a problem with getting rid of those, it's easy enough to
>> register them inside the worker and it's safe since we start with
>> blocked signals. I seem to remember some discussion about why they were
>> added but I can't find a reference anymore. Alvaro, do you remember?
>
> I left them there because it was easy; but they were absolutely
> necessary only until we decided that we would start the worker's main
> function with signals blocked.  I don't think there's any serious reason
> not to remove them now.

All right, done.  FWIW, I think starting the worker's main with
signals blocked was definitely the right decision.

I think we have consensus to back-patch the other API changes as well.I'll work up a patch for that.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: proposal - psql - show longest tables
Next
From: Robert Haas
Date:
Subject: Re: proposal - psql - show longest tables