Postgres Pro
Downloads
Home   >   mailing lists

Re: Set all variable-length fields of pg_attribute to null on column drop - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Set all variable-length fields of pg_attribute to null on column drop
Date
Msg-id CA+TgmobLKU+Naw8mk2qDYfqHQZ3xwvyNRaORWRVyzN4-G-kEew@mail.gmail.com
Whole thread Raw
In response to Set all variable-length fields of pg_attribute to null on column drop  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Tree view 
On Thu, Nov 30, 2023 at 6:24 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> I noticed that when a column is dropped, RemoveAttributeById() clears
> out certain fields in pg_attribute, but it leaves the variable-length
> fields at the end (attacl, attoptions, and attfdwoptions) unchanged.
> This is probably harmless, but it seems wasteful and unclean, and leaves
> potentially dangling data lying around (for example, attacl could
> contain references to users that are later also dropped).
>
> I suggest the attached patch to set those fields to null when a column
> is marked as dropped.

I haven't reviewed the patch, but +1 for the idea.

--
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: pg_upgrade and logical replication
Next
From: vignesh C
Date:
Subject: Re: pg_upgrade and logical replication