Re: pgsql: TAP test for logical decoding on standby - Mailing list pgsql-hackers

On Sat, Apr 8, 2023 at 5:26 AM Andres Freund <andres@anarazel.de> wrote:
> TAP test for logical decoding on standby

Small nitpicks:

1. The test names generated by check_slots_conflicting_status() start
with a capital letter, while most other test names start with a
lower-case letter.

2. The function is called 7 times, 6 with a true argument and 1 with a
false argument, but the test name only depends on whether the argument
is true or false, so we get the same test name 6 times. Maybe there's
not a reasonable way to do better, I'm not sure, but it's not ideal.

--
Robert Haas
EDB: http://www.enterprisedb.com