Re: [COMMITTERS] pgsql: Add hash partitioning. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [COMMITTERS] pgsql: Add hash partitioning.
Date
Msg-id CA+TgmobH1aEgmC9d6HSe8T-ev9L-GPBiMGq5+bEirszSzqK6xg@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add hash partitioning.  (amul sul <sulamul@gmail.com>)
List pgsql-hackers
On Mon, Nov 20, 2017 at 7:46 AM, amul sul <sulamul@gmail.com> wrote:
> Thanks for fixing this function.  Patch looks good to me, except column number
> in the following errors message should to be 2.
>
> 354 +SELECT satisfies_hash_partition('mchash'::regclass, 2, 1,
> NULL::int, NULL::int);
> 355 +ERROR:  column 1 of the partition key has type "text", but
> supplied value is of type "integer"
>
> Same at the line # 374 & 401 in the patch.

Oops.  Looks like the indexing should be 1-based rather than 0-based.
Committed with that change.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: feature request: consume asynchronous notification via a function
Next
From: Tom Lane
Date:
Subject: Re: View with duplicate GROUP BY entries