Re: Unportable code in autoprewarm.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Unportable code in autoprewarm.c
Date
Msg-id CA+TgmobFF9Ev_JjfgatMCRJtdpmXwQqrs2rU5jTQ6t_gmYkZyw@mail.gmail.com
Whole thread Raw
In response to Unportable code in autoprewarm.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, May 2, 2018 at 3:21 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Is there a reason why this record count needs to be int64 rather than
> plain int, and if so what?  This code is not exactly well documented,
> but it looks to me like the number of records should be bounded by
> NBuffers, which is an int and is unlikely ever to not be an int.
> So I'm inclined to just flush autoprewarm.c's use of int64 counters
> altogether.

I don't know of a reason not to make that change.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Is there a memory leak in commit 8561e48?
Next
From: Yuriy Zhuravlev
Date:
Subject: Re: Is a modern build system acceptable for older platforms