Re: PATCH: Improve DROP FUNCTION hint - Mailing list pgsql-hackers

From Robert Haas
Subject Re: PATCH: Improve DROP FUNCTION hint
Date
Msg-id CA+TgmobFCxZRFw0wmEH_Rmnk8op5fTsYV-xL1UsPsbU-RC5oiA@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: Improve DROP FUNCTION hint  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Mon, Jun 11, 2012 at 11:12 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Sat, Jun 9, 2012 at 11:42 AM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>> Hi,
>>
>> Attached is a small patch to improve the HINT message produced by
>> CREATE OR REPLACE FUNCTION when the new function definition conflicts
>> with the old definition. With this patch the hint now includes the
>> function's name and signature as a directly pasteable SQL command. So,
>> for example, instead of
>>
>> psql:functions.sql:70: ERROR:  cannot change return type of existing function
>> HINT:  Use DROP FUNCTION first.
>>
>> it now says
>>
>> psql:functions.sql:70: ERROR:  cannot change return type of existing function
>> HINT:  Use DROP FUNCTION foo(integer,integer) first.
>>
>> which saves having to open the file, find the function and then type
>> in the DROP statement manually.
>
> +1.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Nils Goroll
Date:
Subject: why roll-your-own s_lock? / improving scalability
Next
From: Josh Berkus
Date:
Subject: Re: pg_stat_lwlocks view - lwlocks statistics