Re: [HACKERS] Tuple-routing for certain partitioned tables notworking as expected - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] Tuple-routing for certain partitioned tables notworking as expected
Date
Msg-id CA+TgmobAABu7=X8Gzgk+fbRMie=r+CT=4JAAZhvkYqdQqomMbA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Tuple-routing for certain partitioned tables notworking as expected  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: [HACKERS] Tuple-routing for certain partitioned tables notworking as expected  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
On Mon, Aug 21, 2017 at 7:45 AM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> If there are no objections, I'll add this to the open item list for v10.

This seems fairly ad-hoc to me.  I mean, now you have
CheckValidResultRel not being called in just this one case -- but that
bypasses all the checks that function might do, not just this one.  It
so happens that's OK at the moment because CheckCmdReplicaIdentity()
doesn't do anything in the insert case.

I'm somewhat inclined to just view this as a limitation of v10 and fix
it in v11.  If you want to fix it in v10, I think we need a different
approach -- just ripping the CheckValidResultRel checks out entirely
doesn't seem like a good idea to me.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] What users can do with custom ICU collations inPostgres 10
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] Re: ICU collation variant keywords and pg_collationentries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE andwork_mem values)