Re: [HACKERS] [PATCH] Use $ parameters as replacement characters for pg_stat_statements - Mailing list pgsql-hackers

From Robert Haas
Subject Re: [HACKERS] [PATCH] Use $ parameters as replacement characters for pg_stat_statements
Date
Msg-id CA+Tgmob=hLjnj9KziwYDVUfdy9REV+YhPeu+KncPE-w2vtRr1g@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Use $ parameters as replacement characters forpg_stat_statements  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] [PATCH] Use $ parameters as replacement characters for pg_stat_statements  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Mar 1, 2017 at 8:21 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> On 2/28/17 20:01, Lukas Fittl wrote:
>> Currently pg_stat_statements replaces constant values with ? characters.
>> I've seen this be a problem on multiple occasions, in particular since
>> it conflicts with the use of ? as an operator.
>>
>> I'd like to propose changing the replacement character from ? to instead
>> be a parameter (like $1).
>
> Hmm, I think this could confuse people into thinking that the queries
> displayed were in fact prepared queries.
>
> Maybe we could gather some more ideas.

Perhaps there could be a choice of behaviors.  Even if we all agreed
that parameter notation was better in theory, there's something to be
said for maintaining backward compatibility, or having an option to do
so.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: [HACKERS] Logical replication existing data copy
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] 2017-03 Commitfest In Progress