Re: RFC: replace pg_stat_activity.waiting with something more descriptive - Mailing list pgsql-hackers

From Robert Haas
Subject Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Date
Msg-id CA+Tgmob8vksW6ptOMfREFnr6spsxtCf6VjeJp4RCx9Ow9cpBSQ@mail.gmail.com
Whole thread Raw
In response to Re: RFC: replace pg_stat_activity.waiting with something more descriptive  (Merlin Moncure <mmoncure@gmail.com>)
Responses Re: RFC: replace pg_stat_activity.waiting with something more descriptive  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Mon, Jun 22, 2015 at 4:40 PM, Merlin Moncure <mmoncure@gmail.com> wrote:
> Instead of changing the column, can't we add a new one?  Adjusting
> columns in PSA requires the innumerable queries written against it to
> be adjusted along with all the wiki instructions to dev ops for
> emergency stuck query detection etc etc.   I would also prefer to
> query 'waiting' in some cases, especially when in emergency
> situations; it's faster to type.

If people feel strongly about backward compatibility, yes, we can do
that.  However, if waiting continues to mean "on a heavyweight lock"
for backward compatibility, then you could sometimes have waiting =
false but wait_state non-null.  That seems confusing enough to be a
bad plan, at least to me.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Next
From: Robert Haas
Date:
Subject: Re: NULL passed as an argument to memcmp() in parse_func.c