Postgres Pro
Downloads
Home   >   mailing lists

Re: Convert *GetDatum() and DatumGet*() macros to inline functions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Convert *GetDatum() and DatumGet*() macros to inline functions
Date
Msg-id CA+Tgmob772QiakPJb-xFKTNbZULyAGxJHUcGLm7bcig=jSHiqw@mail.gmail.com
Whole thread Raw
In response to Re: Convert *GetDatum() and DatumGet*() macros to inline functions  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Tree view 
On Tue, Aug 30, 2022 at 10:25 AM Aleksander Alekseev
<aleksander@timescale.com> wrote:
> > Yeah, I don't see a reason to back-patch a change like this
>
> Maybe we should consider backporting at least 0001 patch, partially
> perhaps? I believe if fixes pretty cursed pieces of code, e.g:
>
> ```
>              pg_cryptohash_ctx *context =
> -            (pg_cryptohash_ctx *) PointerGetDatum(foundres);
> +            (pg_cryptohash_ctx *) DatumGetPointer(foundres);
> ```

Sure, back-porting the bug fixes would make sense to me.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Convert *GetDatum() and DatumGet*() macros to inline functions
Next
From: Pavel Stehule
Date:
Subject: Re: \pset xheader_width page as default? (Re: very long record lines in expanded psql output)