Re: new heapcheck contrib module - Mailing list pgsql-hackers

From Robert Haas
Subject Re: new heapcheck contrib module
Date
Msg-id CA+Tgmob5BZF61Fm8Eo9wqu1uACw21wQ3MhpGo+t511RVjxc0xg@mail.gmail.com
Whole thread Raw
In response to Re: new heapcheck contrib module  (Mark Dilger <mark.dilger@enterprisedb.com>)
List pgsql-hackers
On Thu, Oct 22, 2020 at 4:04 PM Mark Dilger
<mark.dilger@enterprisedb.com> wrote:
> I think the compiler warning was about fxid not being set.  The callers pass NULL for status if they don't want
statuschecked, so writing *status unconditionally would be an error.  Also, if the xid being checked is out of bounds,
wecan't check the status of the xid in clog. 

Sorry, you're (partly) right. The new logic is a lot more clear that
we never used that uninitialized.

I'll remove the extra semi-colon and commit this.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: new heapcheck contrib module
Next
From: Tom Lane
Date:
Subject: Re: new heapcheck contrib module