Re: patch: prevent user from setting wal_buffers over 2GB bytes - Mailing list pgsql-hackers

From Robert Haas
Subject Re: patch: prevent user from setting wal_buffers over 2GB bytes
Date
Msg-id CA+Tgmob4Yj7KZszkjVHtkPX2HXQZf3WbXKW=KFg8+33F8QFR=g@mail.gmail.com
Whole thread Raw
In response to patch: prevent user from setting wal_buffers over 2GB bytes  (Josh Berkus <josh@agliodbs.com>)
List pgsql-hackers
On Thu, Jul 30, 2015 at 9:17 PM, Josh Berkus <josh@agliodbs.com> wrote:
> In guc.c, the maximum for wal_buffers is INT_MAX.  However, wal_buffers
> is actually measured in 8KB buffers, not in bytes.  This means that
> users are able to set wal_buffers > 2GB.  When the database is started,
> this can cause a core dump if the WAL offset is > 2GB.

Why does this cause a core dump?  We could consider fixing whatever
the problem is rather than capping the value.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Autonomous Transaction is back
Next
From: Alvaro Herrera
Date:
Subject: Re: brin index vacuum versus transaction snapshots