Re: PATCH: optimized DROP of multiple tables within a transaction - Mailing list pgsql-hackers

From Robert Haas
Subject Re: PATCH: optimized DROP of multiple tables within a transaction
Date
Msg-id CA+Tgmob4RDh20_USdtSSyMnX-F8n9_1HWLOHf2-BaJWARKiY_Q@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: optimized DROP of multiple tables within a transaction  (Tomas Vondra <tv@fuzzy.cz>)
Responses Re: PATCH: optimized DROP of multiple tables within a transaction  (Tomas Vondra <tv@fuzzy.cz>)
List pgsql-hackers
On Sun, Dec 23, 2012 at 8:41 PM, Tomas Vondra <tv@fuzzy.cz> wrote:
> Attached is a patch with fixed handling of temporary relations. I've
> chosen to keep the logic in DropRelFileNodeAllBuffers and rather do a
> local copy without the local relations.

This looks pretty good, although it needs some cleanup for coding
style.  And I think BSEARCH_LIMIT cuts a bit too broadly as a name for
the constant.

Granted that we can't decide on an exact value for BSEARCH_LIMIT, is
there any data to indicate that 10 is at least an approximately
correct value?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: enhanced error fields
Next
From: Greg Smith
Date:
Subject: Re: buffer assertion tripping under repeat pgbench load