Re: RFC: replace pg_stat_activity.waiting with something more descriptive - Mailing list pgsql-hackers

From Robert Haas
Subject Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Date
Msg-id CA+Tgmob-hmvCZaL91fg8TOz-mKMJMHMNiQiof4e6kJ646UODww@mail.gmail.com
Whole thread Raw
In response to Re: RFC: replace pg_stat_activity.waiting with something more descriptive  (Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>)
List pgsql-hackers
On Sun, Sep 13, 2015 at 11:09 AM, Ildus Kurbangaliev
<i.kurbangaliev@postgrespro.ru> wrote:
> This is pretty much the same that my patch does. There is
> two API calls (for a size determination and a tranche creation), except
> MainLWLockArray is used only for individual LWLocks.

It's not really the same.  Your patch doesn't provide any interlock to
ensure that the number of locks requested for a particular subsystem
during shmem sizing is the same as the number actually created during
shmem setup.  That's an interlock I'd really like to have.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: RLS open items are vague and unactionable
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] Refactoring of LWLock tranches