Re: extensible options syntax for replication parser? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: extensible options syntax for replication parser?
Date
Msg-id CA+TgmoasYGNVdgpQS4nE+T0AvE6pmLtK2GB3Ci07ey3cdA+uQQ@mail.gmail.com
Whole thread Raw
In response to Re: extensible options syntax for replication parser?  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: extensible options syntax for replication parser?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Wed, Jun 24, 2020 at 11:51 AM Robert Haas <robertmhaas@gmail.com> wrote:
> Thanks for the review. v2 attached, hopefully fixing the compilation
> issue you mentioned.

Tushar Ahuja reported to me off-list that my basebackup refactoring
patch set was changing whether or not the following message appeared:

NOTICE:  WAL archiving is not enabled; you must ensure that all
required WAL segments are copied through other means to complete the
backup

That patch set includes this patch, and the reason for the behavior
difference turned out to be that I had gotten an if-test that is part
of this patch backwards. Here is v3, fixing that. It is a little
disappointing that this mistake didn't cause any existing regression
tests to fail.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] Custom compression methods
Next
From: Bruce Momjian
Date:
Subject: Re: Wrong example in the bloom documentation