Re: refactoring basebackup.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: refactoring basebackup.c
Date
Msg-id CA+TgmoaqvdT-u3nt+_kkZ7bgDAyqDB0i-+XOMmr5JN2Rd37hxw@mail.gmail.com
Whole thread Raw
In response to Re: refactoring basebackup.c  (Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>)
Responses Re: refactoring basebackup.c  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Wed, Feb 9, 2022 at 8:41 AM Abhijit Menon-Sen <ams@toroid.org> wrote:
> It took me a while to assimilate these patches, including the backup
> targets one, which I hadn't looked at before. Now that I've wrapped my
> head around how to put the pieces together, I really like the idea. As
> you say, writing non-trivial integrations in C will take some effort,
> but it seems worthwhile. It's also nice that one can continue to use
> pg_basebackup to trigger the backups and see progress information.

Cool. Thanks for having a look.

> Yes, it looks simple to follow the example set by basebackup_to_shell to
> write a custom target. The complexity will be in whatever we need to do
> to store/forward the backup data, rather than in obtaining the data in
> the first place, which is exactly as it should be.

Yeah, that's what made me really happy with how this came out.

Here's v2, rebased and with documentation added.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Design of pg_stat_subscription_workers vs pgstats
Next
From: Andres Freund
Date:
Subject: Re: Fix overflow in DecodeInterval