Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c
Date
Msg-id CA+TgmoanAmR+6zbVL6r=Dz=_TGpSTWndiWTOc2fJ23GWn+O+QQ@mail.gmail.com
Whole thread Raw
In response to Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Oct 12, 2011 at 7:07 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Phil Sorber <phil@omniti.com> writes:
>> Then there is a separate section of code that is called as a separate
>> function 'dumpUserConfig()' that does other role attributes like
>> 'ALTER ROLE bob SET role TO charlie'. These are the ALTER's that can
>> have dependencies on other roles.
>
> Right.  Phrased that way, this is an obvious improvement, and I concur
> that it doesn't look like it could break anything that works now.
> The more general problem remains to be solved, but we might as well
> apply this.

OK, done.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Call stacks and RAISE INFO
Next
From: Peter Geoghegan
Date:
Subject: Re: Large C files