Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c
Date
Msg-id 4588.1318460842@sss.pgh.pa.us
Whole thread Raw
In response to Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c  (Phil Sorber <phil@omniti.com>)
Responses Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Phil Sorber <phil@omniti.com> writes:
> Then there is a separate section of code that is called as a separate
> function 'dumpUserConfig()' that does other role attributes like
> 'ALTER ROLE bob SET role TO charlie'. These are the ALTER's that can
> have dependencies on other roles.

Right.  Phrased that way, this is an obvious improvement, and I concur
that it doesn't look like it could break anything that works now.
The more general problem remains to be solved, but we might as well
apply this.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: ALTER EXTENSION .. ADD/DROP weirdness
Next
From: "David E. Wheeler"
Date:
Subject: Re: Patch: Perl xsubpp