Re: [Windows,PATCH] Use faster, higher precision timer API - Mailing list pgsql-hackers

On Thu, Oct 23, 2014 at 5:41 AM, David Rowley <dgrowleyml@gmail.com> wrote:
> On Thu, Oct 23, 2014 at 1:27 AM, Craig Ringer <craig@2ndquadrant.com> wrote:
>> Here's an updated patch addressing David's points.
>> I haven't had a chance to test it yet, on win2k8 or win2k12 due to
>> pgconf.eu .
>>
> Hi Craig, thanks for the fast turnaround.
>
> I've just had a look over the patch again:
>
> +               DWORD errcode = GetLastError();
> +               Assert(errcode == ERROR_PROC_NOT_FOUND);
>
> I'm not a big fan of this. It seems quite strange to be using Assert in this
> way.

Agreed - I think if you want an error check here it should use elog()
or ereport(), not Assert().

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company