Re: Atomics in localbuf.c - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Atomics in localbuf.c
Date
Msg-id CA+TgmoaiUy_eHhG9fhA_Men28Y1Es-HbKSXbmrCHCQYh-ribBg@mail.gmail.com
Whole thread Raw
In response to Re: Atomics in localbuf.c  (Antonin Houska <ah@cybertec.at>)
Responses Re: Atomics in localbuf.c  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Fri, Mar 6, 2020 at 2:04 AM Antonin Houska <ah@cybertec.at> wrote:
> ok. What I missed is that BufferDesc.state is declared as pg_atomic_uint32
> rather than plain int, so the pg_atomic_...() functions should be used
> regardless the buffer is shared or local. Sorry for the noise.

Right. I thought, though, that your question was why we did it that
way instead of just declaring them as uint32. I'm not sure it's very
important, but I think that question hasn't really been answered.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Jeremy Finzel
Date:
Subject: Re: PHJ file leak.
Next
From: Fujii Masao
Date:
Subject: Re: Crash by targetted recovery