Re: Using ProcSignal to get memory context stats from a running backend - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Using ProcSignal to get memory context stats from a running backend
Date
Msg-id CA+TgmoaiOOqZpJ4vOD3oXVqgp8bUn6Mdsg-bov6exmY1mEM5VQ@mail.gmail.com
Whole thread Raw
In response to Re: Using ProcSignal to get memory context stats from a running backend  (Craig Ringer <craig@2ndquadrant.com>)
Responses Re: Using ProcSignal to get memory context stats from a running backend
List pgsql-hackers
On Tue, Dec 19, 2017 at 8:44 AM, Craig Ringer <craig@2ndquadrant.com> wrote:
> I didn't want to mess with the MemoryContextMethods and expose a
> printf-wrapper style typedef in memnodes.h, so I went with a hook global.

That looks pretty grotty to me.  I think if you want to elog/ereport
this, you need to pass another argument to MemoryContextStats() or add
another memory context method.  This is pretty much a textbook example
of the wrong way to use a global variable, IMHO.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256
Next
From: Peter Eisentraut
Date:
Subject: update portal-related memory context names and API